From 1970 to 1997 he was the Labour MP for Aberdeen North.  He served as Under-Secretary of State for Scotland in 1974–75 and shadow Secretary of State for Transport in 1985-1988, as well as a three year term on the Scottish Affairs Committee (1979-1982) and taking on the role of Chairman between 1981-1982.

He was made a Labour Peer in 1997.